We broke many references in the MICADO DRLD. These changes are required to fix it.
Thanks, test seemed to work!
Hugo Buddelmeijer (cd5e3585) at 19 Sep 08:52
Willem-Jan Vriend (279cfe0a) at 19 Sep 08:52
Merge branch 'hb/updatescopesimandirdb' into 'develop'
... and 8 more commits
This PR should make MicadoWISE work with the latest ScopeSim and IRDB.
The specific version of the IRDB used to be hardcoded by having the IRDB as a git-submodule. However, this coupling has been removed in !357, therefor always using the latest IRDB. MAORY has been renamed to MORFEO in the IRDB, thereby breaking MicadoWISE.
Marked draft to let the tests run first.
Project ID: micado-micadowise
All abstractautoformatter formatting issues have been fixed. If an assist-MR has been merged, do not forget to update your local hb/updatescopesimandirdb
branch via a git pull
command.
CI Bot (e83b19cb) at 18 Sep 20:05
Auto-format files with abstractautoformatter. Assist-MR for !379.
Note: after merging this MR, do not forget to update your local hb/updatescopesimandirdb
branch via a git pull
command.
Hugo Buddelmeijer (cd5e3585) at 18 Sep 20:05
Merge branch 'assist/autoformat/hb/updatescopesimandirdb/b40511de' ...
... and 1 more commit
Auto-format files with abstractautoformatter. Assist-MR for !379.
Note: after merging this MR, do not forget to update your local hb/updatescopesimandirdb
branch via a git pull
command.
Some files are not formatted correctly according to abstractautoformatter:
The assist-MR !380 (merged) has been created to fix the formatting.
CI Bot (e83b19cb) at 18 Sep 18:53
Auto-format files with abstractautoformatter
... and 6 more commits
Hugo Buddelmeijer (b40511de) at 18 Sep 17:45
Install the latest version of ScopeSim[_Templates] for assist MR
Hugo Buddelmeijer (cc21c43c) at 18 Sep 17:26
Also update .gitlab-ci.yml
This PR should make MicadoWISE work with the latest ScopeSim and IRDB.
The specific version of the IRDB used to be hardcoded by having the IRDB as a git-submodule. However, this coupling has been removed in !357, therefor always using the latest IRDB. MAORY has been renamed to MORFEO in the IRDB, thereby breaking MicadoWISE.
Marked draft to let the tests run first.
We should have WISE recipes for processed data.
All processed data is essentially:
make()
, store()
, commit()
. # For a given set of deperistedflats and masterdark.
myrecipe = McdImgFlat()
# Should perhaps be moved to the make method.
mymasterextensions = [
MasterFlatExtension(BITPIX=-64, NAXIS=2) for _ in mydetectorlist
]
mymasterflat = MasterFlat(
recipe=myrecipe,
flats=mydepersistedflats,
masterdark=mymasterdark,
extensions=mymasterextensions,
)
mymasterflat.make()
mymasterflat.save_fits()
mymasterflat.store()
mymasterflat.commit()
All processed data follows exactly this structure.
Process parameters can be entered through the Recipe object, but this is a bit awkward and none of the current prototype Python or ESO C recipes actually support process parameters.
The first three ESO Recipes in the FDR pipeline are
These first three recipes should be implemented first. There are already C implementations for McdDetDark and McdImgFlat, and these should be used automatically when make()
is called (if installed).
Note that the McdDetDepersist ESO recipe is used to produce various data products, in particular for this exercise, it produces DepersistedDark and DepersistedFlat. It makes sense to only have one recipe that can create both DepersistedDark and DepersistedFlat, because in total there are almost 20 different depersisted image classes. (DepersistedDark and DepersistedFlat will not exist in the final pipeline, but that is not so important for this exercise.)