Skip to content

Draft: Put non-linearity correction before persistence correction

Hugo Buddelmeijer requested to merge hb/feature/reordernonlin1 into develop

This moves the non-linearity correction before the persistence correction.

This MR is primarily for demonstration purposes: to show the power of VO-DSL. Several of our RIXes noted that we should do the non-linearity correction earlier in the pipeline. This reordering has a profound effect on our pipeline as you will see, but is rather straightforward to do.

Only 4 lines had to be changed in the vodsl (first commit, !264 (diffs)) to move the non-linearity in the pipeline, and 1 line in a figure-generating script. However, in total those 5 lines resulted in a change of almost 8000 lines in 176 files (other two commits, !264 (diffs)), all automatically generated. Admittedly most of those lines are in figures (ditaa, svg, tikz), but still, editing all those files by hand would be an enormous amount of work, while now it was only about an hour of manual work. So I'm really happy we went this VO-DML route.

(That MR should not yet be merged for various reasons. In particular we should discuss such pipeline changes first.)

Edited by Hugo Buddelmeijer

Merge request reports